Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make float32 literals stringifying behave in JS the same as in C #22500

Merged
merged 1 commit into from
Aug 17, 2023
Merged

make float32 literals stringifying behave in JS the same as in C #22500

merged 1 commit into from
Aug 17, 2023

Conversation

ringabout
Copy link
Member

follow up #18531 JS backend now behaves like VM and C backend

@ringabout ringabout changed the title make addFloat behave in JS the same as in C make float literals stringify behave in JS the same as in C Aug 17, 2023
@ringabout ringabout changed the title make float literals stringify behave in JS the same as in C make float32 literals stringify behave in JS the same as in C Aug 17, 2023
@ringabout ringabout changed the title make float32 literals stringify behave in JS the same as in C make float32 literals stringifying behave in JS the same as in C Aug 17, 2023
@Araq Araq added the merge_when_passes_CI mergeable once green label Aug 17, 2023
@Araq Araq merged commit 7fababd into devel Aug 17, 2023
@Araq Araq deleted the pr_js_float32 branch August 17, 2023 16:52
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 7fababd

Hint: mm: orc; opt: speed; options: -d:release
169244 lines; 8.490s; 611.457MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq