add os.pathExists; fix RFCs/issues/121 #17577
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not review yet, I'm still trying to figure whether
pathExists
orpathKind
is the most sensible API to add.TODO
pathExists
, maybe we should havepathKind
which could return:note:
PathComponent
is IMO the wrong thing to return here, it's not what the OS provides directly, doesn't distinguish broken symlinks, doesn't have a category for device files etc