Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make unary minus part of number literals, refs #17020 #17488

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

Araq
Copy link
Member

@Araq Araq commented Mar 23, 2021

No description provided.

@timotheecour
Copy link
Member

timotheecour commented Mar 24, 2021

@narimiran I'm still seeing builds.sr.ht CI triggered despite #17479 (comment)

no sr.ht BSD CIs anymore.

this PR triggers

builds.sr.ht: freebsd.yml
builds.sr.ht: openbsd_1.yml
builds.sr.ht: openbsd_0.yml

(eg https://builds.sr.ht/~araq/job/468294 https://builds.sr.ht/~araq/job/468295)

note

https://builds.sr.ht/~araq/job/468294 errors with

Name: tests/array/tarray.nim c
Action: run
Result: reNimcCrash
-------- Expected -------

--------- Given  --------
$ /home/build/Nim/bin/nim c --hints:on -d:testing --clearNimblePath --nimblePath:build/deps/pkgs --nimCache:nimcache/tests/array/tarray.nim_4a8a08f09d37b73795649038408b5f33 tests/array/tarray.nim
Hint: used config file '/usr/home/build/Nim/config/nim.cfg' [Conf]
Hint: used config file '/usr/home/build/Nim/config/config.nims' [Conf]
Hint: used config file '/usr/home/build/Nim/tests/config.nims' [Conf]
fatal.nim(53)            sysFatal
Error: unhandled exception: 'sons' is not accessible using discriminant 'kind' of type 'TNode' [FieldDefect]

-------------------------

+ exit 1

(see also timotheecour#666)

@Araq Araq merged commit 86af2f7 into devel Mar 24, 2021
@Araq Araq deleted the araq-unary-minus branch March 24, 2021 08:47
@narimiran
Copy link
Member

@narimiran I'm still seeing builds.sr.ht CI triggered despite #17479 (comment)

I think it is because of Araq's branch on nim-lang. Look at other PRs, and you'll see no such triggers.

alaviss added a commit to alaviss/nim.nvim that referenced this pull request Mar 24, 2021
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
…ng#17488)

* make unary minus part of number literals, refs nim-lang#17020
* fixes regression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants