Fix sleepAsync

[juancarlospaco]

import asyncdispatch, times

proc main(a: float or int) {.async.} =
  let t = now()
  echo "BEFORE\T", t, '\T', a
  await sleepAsync(a)
  echo "AFTER\T", t - now(), '\n'

waitFor main(1)  # Control
waitFor main(0.0)
waitFor main(-0.0)
waitFor main(1.0)
waitFor main(-1.0)
waitFor main(-1.0)
waitFor main(NaN)
waitFor main(+Inf)
waitFor main(-Inf)
waitFor main(Inf)

• Only package ws is failing CI. /c @treeform

[treeform]

So sleepAsync used to take a float? API change?

[treeform]

proc sleepAsync(ms: int): owned(Future[void])
    first type mismatch at position: 1
    required type for ms: int
    but expression '1000.0 * seconds' is of type: float
  
  expression: sleepAsync(1000.0 * seconds)

Really strange?

[timotheecour]

the proper fix IMO is timotheecour#617

we should have type safe API's that are self-documenting and hard to misuse by using values with time units, the only question is whether it should be TimeInterval or Duration.

My recommendation is to add an overload that takes a TimeInterval or Duration (we need to figure out which of those 2 makes sense).

then users can use sleepAsync(145.microseconds) or sleepAsync(initDuration(seconds = 2)) and everything is self documenting.

sleepAsync(1000.0 * seconds)
Really strange?

well that stems from this PR... i guess your point is that it's a breaking change.

note

current API seems to truncate at 1ms smallest resolution, but that shouldn't dictate API, a better implementation should honor wait times smaller than 1ms, which this PR doesn't account for.