Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add std/setutils to lib.rst #16791

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Add std/setutils to lib.rst #16791

merged 2 commits into from
Jan 22, 2021

Conversation

konsumlamm
Copy link
Contributor

@konsumlamm konsumlamm commented Jan 22, 2021 •
edited
Loading

lib.rst:

  • add std/setutils
  • add missing std/ prefix for packedsets
  • small formatting

setutils.nim:

  • improve doc comments for setutils

Refs #16656.

@konsumlamm
Add std/setutils to lib.rst
6d9ab0d 
Improve doc comments for setutils
@Clyybber
Copy link
Contributor

The formatting changes to doc/lib.rst should be reverted as inline literals need `` instead of ` in RST (try viewing the file on github) and there isn't a good reason to make doc/lib.rst not adhere to the RST spec.

timotheecour
timotheecour reviewed Jan 22, 2021
View reviewed changes
@konsumlamm
Adhere to the RST spec
6d87de9 
Use no UFCS in toSet
@Clyybber Clyybber merged commit 72bbd07 into nim-lang:devel Jan 22, 2021
@konsumlamm konsumlamm mentioned this pull request Jan 22, 2021
Closed
14 tasks
@konsumlamm konsumlamm deleted the setutils branch February 14, 2021 14:38
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@konsumlamm @ardek66
Add std/setutils to lib.rst (nim-lang#16791)
202d954 
* Add std/setutils to lib.rst

Improve doc comments for setutils

* Adhere to the RST spec

Use no UFCS in toSet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheecour timotheecour timotheecour left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konsumlamm @Clyybber @timotheecour