Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12864 static params were mutating arg types during sigmatch; fix #12713 ; refs #13529 #13976

Merged
merged 4 commits into from
Apr 14, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Apr 14, 2020

Note: the change to typetraits.nim was necessary after the fix for #12864 but is a good change anyways.

@timotheecour timotheecour changed the title fix #12864 static params were mutating arg types during sigmatch [WIP] fix #12864 static params were mutating arg types during sigmatch Apr 14, 2020
@Clyybber
Copy link
Contributor

Would also fix #12713 .
Not sure if its the right way to fix this though, as I was under the assumption that sigmatch relies on this mutation (which is the culprit here).

@timotheecour timotheecour changed the title [WIP] fix #12864 static params were mutating arg types during sigmatch [WIP] fix #12864 static params were mutating arg types during sigmatch; refs #13529 Apr 14, 2020
@timotheecour timotheecour changed the title [WIP] fix #12864 static params were mutating arg types during sigmatch; refs #13529 fix #12864 static params were mutating arg types during sigmatch; refs #13529 Apr 14, 2020
@timotheecour timotheecour reopened this Apr 14, 2020
@timotheecour
Copy link
Member Author

Would also fix #12713 .

indeed, thx for pointing it out, I verified it fixes all cases and added test cases for the last 2 examples (avoiding dependency of 1st one)

Not sure if its the right way to fix this though, as I was under the assumption that sigmatch relies on this mutation (which is the culprit here).

all other cases don't mutate, I think this was just a bug

@timotheecour timotheecour changed the title fix #12864 static params were mutating arg types during sigmatch; refs #13529 fix #12864 static params were mutating arg types during sigmatch; fix #12713 ; refs #13529 Apr 14, 2020
@Araq
Copy link
Member

Araq commented Apr 14, 2020

Thank you! Excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeFormat() should raise an error but craches at compilation time A few bugs related to static parameters
3 participants