Add barebones asynchttpserver tests #13883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Apr 5, 2020
| @@ -0,0 +1,119 @@ | |||
| discard """ | |||
| cmd: "nim c --threads:on $file" | |||
There was a problem hiding this comment.
Is threads:on needed here though? I don't see you using threads anywhere in the file
|
I like it. We'll later see if it's a "flaky" test or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression in #13866 showed that there were no tests for
asynchttpserverso I took a stab at some barebones tests which at least try to:While the
requestproc in the tests could be simplified with another template I think future test cases might want to perform multiple requests.Since this is my first 'serious' Nim code aside from the PR for the abovementioned ticket (a one line change) I'd like some help getting it up to par.