fixes #12747 [backport] #13651
Merged
fixes #12747 [backport] #13651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Mar 14, 2020
compiler/transf.nim
Outdated
| @@ -563,7 +563,7 @@ proc putArgInto(arg: PNode, formal: PType): TPutArgInto = | |||
| return paDirectMapping # XXX really correct? | |||
| # what if ``arg`` has side-effects? | |||
| case arg.kind | |||
| of nkEmpty..nkNilLit: | |||
| of nkEmpty..nkNilLit, nkDotExpr: | |||
There was a problem hiding this comment.
What if it's sideEffectHere().field? Then we cannot use a direct mapping, can we?
|
I have also added nkObjConstr handling as well and also noticed that nkExprColonExpr is not handled for nkPar, nkTupleConstr. |
|
Please rebase |
|
Ready for review |
Clyybber
approved these changes
Mar 16, 2020
narimiran
pushed a commit
that referenced
this pull request
Apr 14, 2020
* fixes #12747 * fix tests * improve code style Co-authored-by: cooldome <[email protected]> (cherry picked from commit 613ea6e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.