-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idxmin & idxmax, continuation #13208
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8e2274c
Add idxmin() which returns the index of the minimum value
facorazza cf07d94
Add idxmax() which returns the index of the maximum value
facorazza e5fe3d3
Add tests for idxmin()
facorazza d8d3f8c
Add tests for idxmax()
facorazza ed5358b
Remove initialization of result = 0
facorazza 9357bfb
Adds overloading for arrays (no enums indexed arrays yet)
facorazza a950e19
Add support for enum index arrays
facorazza e92b8dd
Fix tests with enum
facorazza 10d434e
Fix tests for idxmax
facorazza d92651e
Change names of the procedures to minIndex and maxIndex
facorazza 33eb586
address Araq's comments:
narimiran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
index is incorrect / imprecise); eg:In case of duplicates, the smallest such index is returned
-1
for s.len == 0 may make more sensecmp
argument, like other procs in std/algorithmargMin
,argMax
more common?