Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpclient SSL doesn't validate certificate CN #784

Closed
zielmicha opened this issue Dec 27, 2013 · 2 comments
Closed

httpclient SSL doesn't validate certificate CN #784

zielmicha opened this issue Dec 27, 2013 · 2 comments
Labels
Medium Priority Standard Library

Comments

@zielmicha
Copy link
Contributor

For example

import httpclient
getContent("https://user.zielm.com/site").echo

works, but certificate is for www.zielm.com and zielm.com.
@dom96 dom96 modified the milestone: 0.9.6 Aug 14, 2014
@flaviut
Copy link
Contributor

flaviut commented Dec 3, 2014

https://github.com/iSECPartners/ssl-conservatory/blob/master/openssl/everything-you-wanted-to-know-about-openssl.pdf?raw=true should be helpful in fixing this issue.

@perpetual-hydrofoil perpetual-hydrofoil mentioned this issue Oct 20, 2017
Closed
@FedericoCeratto FedericoCeratto mentioned this issue Nov 5, 2017
Closed
@FedericoCeratto FedericoCeratto mentioned this issue Nov 26, 2017
Closed
@narimiran
Copy link
Member

narimiran commented Mar 20, 2020 •
edited
Loading

Fixed by @FedericoCeratto in #13697.

Clyybber pushed a commit to Clyybber/Nim that referenced this issue Sep 16, 2023
@zerbina
cgen: split parameter setup from rendering (nim-lang#784)
c9fb1c7 
## Summary

Separate `TLoc` setup for parameters from the rendering logic. This
reduces the amount of side-effects the rendering has, and is a
preparation for separating `TLoc` from `TSym`.

## Details

* move `TLoc` setup for parameters into `prepareParameters`
* inline the single use of `paramStorage`, and use `mapType` for the
  check
* in `genProcParams`, don't re-compute the information now provided by
  the parameters' `TLoc`
* add calls to `prepareParameters` where needed

This also fixes a regression where a procedure's parameter has no
filled-in `TLoc` if the procedure had no prototype emitted previously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Medium Priority Standard Library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dom96 @Araq @zielmicha @Varriount @flaviut @narimiran