Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression(0.18 => devel): hash(cstring) fails in VM #16061

Closed
timotheecour opened this issue Nov 20, 2020 · 0 comments · Fixed by #16551
Closed

regression(0.18 => devel): hash(cstring) fails in VM #16061

timotheecour opened this issue Nov 20, 2020 · 0 comments · Fixed by #16551
Assignees
@ringabout
Labels
Regression Standard Library VM see also `const` label

Comments

@timotheecour
Copy link
Member

hash(cstring) fails in VM

Example

import std/hashes
proc main() =
  echo hash(cstring"abracadabra")
static: main()
main()

Current Output

lib/pure/hashes.nim(326, 33) Error: cannot generate code for: mSlice
murmurHash(toOpenArrayByte(x, 0, x.high))

Expected Output

works

Additional Information

  • fails: devel 1.5.1 b3c3557
  • works: 0.18
@timotheecour timotheecour added VM see also `const` label Standard Library Regression and removed VM see also `const` label labels Nov 20, 2020
@timotheecour timotheecour mentioned this issue Jan 2, 2021
Merged
@ringabout ringabout self-assigned this Jan 2, 2021
ringabout added a commit to ringabout/Nim that referenced this issue Jan 2, 2021
@ringabout
fix nim-lang#16061
154e530
@ringabout ringabout mentioned this issue Jan 2, 2021
Merged
Araq pushed a commit that referenced this issue Jan 2, 2021
@ringabout
fix #16061 (#16551)
e869767
This was referenced Jan 2, 2021
Open
Closed
mildred pushed a commit to mildred/Nim that referenced this issue Jan 11, 2021
@ringabout @mildred
fix nim-lang#16061 (nim-lang#16551)
0b31a5a
ardek66 pushed a commit to ardek66/Nim that referenced this issue Mar 26, 2021
@ringabout @ardek66
fix nim-lang#16061 (nim-lang#16551)
ed2335e
timotheecour added a commit to timotheecour/Nim that referenced this issue Mar 29, 2021
@timotheecour
un-disable a test now that nim-lang#16061 was fixed
d80e521
Araq pushed a commit that referenced this issue Mar 31, 2021
@timotheecour
jsonutils: support cstring (including as Table key); improve docs (#1…
9b67e5c 
…6062)

* jsonutils: support cstring (including as Table key); improve docs
* changelog
* un-disable a test now that #16061 was fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ringabout ringabout

Labels
Regression Standard Library VM see also `const` label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #16061 ringabout/Nim
2 participants
@timotheecour @ringabout