Revert "fix #19600 No error checking on fclose (#19836)"

This reverts commit 04e4a5e.
nim-lang · Sep 2, 2022 · f86a294 · f86a294
1 parent 2a34d14
commit f86a294
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/lib/std/syncio.nim b/lib/std/syncio.nim
@@ -324,9 +324,7 @@ const
 proc close*(f: File) {.tags: [], gcsafe.} =
   ## Closes the file.
   if not f.isNil:
-    let x = c_fclose(f)
-    if x < 0:
-      checkErr(f)
+    discard c_fclose(f)
 
 proc readChar*(f: File): char {.tags: [ReadIOEffect].} =
   ## Reads a single character from the stream `f`. Should not be used in
@@ -691,7 +689,7 @@ when defined(posix) and not defined(nimscript):
 
 proc open*(f: var File, filename: string,
           mode: FileMode = fmRead,
-          bufSize: int = -1): bool {.tags: [], raises: [IOError], benign.} =
+          bufSize: int = -1): bool {.tags: [], raises: [], benign.} =
   ## Opens a file named `filename` with given `mode`.
   ##
   ## Default mode is readonly. Returns true if the file could be opened.

diff --git a/tests/misc/t19600.nim b/tests/misc/t19600.nim