Skip to content

Commit

Permalink
std/lists: Various changes to lists (RFC #303) (#16536)
Browse files Browse the repository at this point in the history
* Various changes to `lists` (RFC #303)

* Removing a non-element is no-op; better tests

* Remove preserves cycles; add appendMove alias; tests.

* Return value for (singly linked) `lists.remove`

* More test for lists.remove

* Moved `lists.append` to the end of the file to see all `add` definitions

* Disable testing js for now

* Use workaround for swap js bug

* Smaller diff

* Undo "silent" deprecation of append

* Correct typo in changelog

Co-authored-by: Timothee Cour <[email protected]>

* Remove `appendMoved`

Co-authored-by: Timothee Cour <[email protected]>

* Don't remove appendMoved

Co-authored-by: Clyybber <[email protected]>
Co-authored-by: Timothee Cour <[email protected]>
  • Loading branch information
3 people authored Feb 8, 2021
1 parent a9f44b7 commit e211a2a
Show file tree
Hide file tree
Showing 3 changed files with 350 additions and 162 deletions.
3 changes: 3 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ with other backends. see #9125. Use `-d:nimLegacyJsRound` for previous behavior.
- Added `math.signbit`.

- Removed the optional `longestMatch` parameter of the `critbits._WithPrefix` iterators (it never worked reliably)
- In `lists`: renamed `append` to `add` and retained `append` as an alias;
added `prepend` and `prependMoved` analogously to `add` and `addMoved`;
added `remove` for `SinglyLinkedList`s.


- Added optional `options` argument to `copyFile`, `copyFileToDir`, and
Expand Down
Loading

0 comments on commit e211a2a

Please sign in to comment.