Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 8, and drop support for PHP <7.2 #9

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Add support for PHP 8, and drop support for PHP <7.2 #9

merged 1 commit into from
Dec 12, 2020

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Dec 12, 2020

Closes #7

@acelaya acelaya mentioned this pull request Dec 12, 2020
Closed
@acelaya
Copy link
Contributor Author

acelaya commented Dec 12, 2020

I'm not sure why scrutinizer failed. The error doesn't give too much information 🤔

@nikolaposa nikolaposa self-assigned this Dec 12, 2020
@nikolaposa nikolaposa self-requested a review December 12, 2020 18:45
@acelaya
Copy link
Contributor Author

acelaya commented Dec 12, 2020

Looks like scrutinizer worked after you re-run it 🙂

@nikolaposa
Copy link
Owner

Worked after retry. 🤷🏻‍♂️

@nikolaposa nikolaposa merged commit 9257f7d into nikolaposa:master Dec 12, 2020
@acelaya acelaya deleted the feature/php8-support branch December 12, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolaposa nikolaposa nikolaposa approved these changes

Assignees

@nikolaposa nikolaposa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8 Support
2 participants
@acelaya @nikolaposa