add missing -ms-grid display property to support IE grid layouts #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelzwronek
pushed a commit
to pawelzwronek/html2canvas
that referenced
this pull request
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A similar PR may already be submitted!
Please search among the Pull request before creating one.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
Before opening a pull request, please make sure all the tests pass locally by running
npm test.Summary
Since IE uses the -ms-grid display property instead of the grid property, the display property list was missing this tag. This caused empty rendering for grid layouts on IE.
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
In IE with a grid layout the library produces an empty image, due to the missing display property (-ms-grid).
Test plan (required)
Create a HTML node with CSS grid (use -ms-grid autoperfixer). Try to create an image of this node in IE. Due to the missing property the image is empty and the node is not rendered correctly.
Demonstrate how the issue/feature can be replicated. For most cases, simply adding an appropriate html/css template into the reftests should be sufficient. Please see other tests there for reference.
Code formatting
Please make sure that code adheres to the project code formatting. Running
npm run formatwill automatically format your code correctly.Closing issues
Fixes #