Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodness: Alfred Workflow #554

Closed
wants to merge 1 commit into from

Conversation

yuriteixeira
Copy link

Alfred Workflow added.

Alfred Workflow added.
Copy link
Owner

@nikitabobko nikitabobko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  1. Please specify the license in your git repo
  2. Please specify how to build .alfredworkflow file from sources
  3. In goodness.adoc, please mention that it's a third party extension (like it's done for raycast)
  4. I want goodness.adoc page contain something that keeps the quality bar. Will you be willing to use --json to make your script more reliable? Add --json flag to all query commands #577 (Once --json is implemented)

I'm curious why did you choose to focus between windows on the currently visible workspaces. Is it because alfread already allows to switch between all windows?

Alternatively, You could also choose to switch between windows on the focused workspaces (the difference between focused workspace and visible workspaces is that, in multi-monitor setup, you have only one focused workspace, but as many visible as many monitors you have)

[#alfred-workflow]
== Alfred Workflow

[alfred,workflow,automation]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line for? When I build the html I don't see anything
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋 (and sorry for the delay).

I copied/pasted an entry from another tool and those looked like tags or something, I can see if missed something.

@nikitabobko
Copy link
Owner

Closing due to inactivity. Feel free to reopen PR, once you fix the comments

@nikitabobko nikitabobko added the pr-rejected Pull Request is rejected label Oct 20, 2024
@yuriteixeira
Copy link
Author

yuriteixeira commented Oct 24, 2024

Thanks!

  1. Please specify the license in your git repo

Sure, will do.

  1. Please specify how to build .alfredworkflow file from sources

Afaik, you need to do it using the Alfred UI (documentation). I can add this reference into my repo's README.md, if that's what you mean.

Screenshot 2024-10-24 at 09 28 38

  1. In goodness.adoc, please mention that it's a third party extension (like it's done for raycast)

Sure, will do.

  1. I want goodness.adoc page contain something that keeps the quality bar. Will you be willing to use --json to make your script more reliable? Add --json flag to all query commands #577 (Once --json is implemented)

Sure! But just to clarify: did I miss it or wasn't it implemented?

I'm curious why did you choose to focus between windows on the currently visible workspaces. Is it because alfread already allows to switch between all windows?

Out of the box (without any 3rd party workflows), Alfred allows to switch between apps, but not windows.

Alternatively, You could also choose to switch between windows on the focused workspaces (the difference between focused workspace and visible workspaces is that, in multi-monitor setup, you have only one focused workspace, but as many visible as many monitors you have)

The intention of my workflo was to allow the user to list all visible windows (amongst all visible workspaces).

@yuriteixeira
Copy link
Author

Btw, it doesn't seem that I have permissions to re-open the PR. Maybe because I didn't push any changes? Anyways, I can ping the admin and ask them to re-open later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-rejected Pull Request is rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants