Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in csv to sql? #3

Closed
freelon opened this issue Jan 11, 2025 · 4 comments
Closed

Mistake in csv to sql? #3

freelon opened this issue Jan 11, 2025 · 4 comments

Comments

@freelon
Copy link

freelon commented Jan 11, 2025

If I do the example then step

  1. "yp pastes our previously yanked items from the “y” register

should be "yP instead. Since, after the previous step, the selection is on the ) and we want to insert within the parentheses.

(fun project, btw!)

@freelon
Copy link
Author

freelon commented Jan 11, 2025

And another one in text into array:
Adding spaces (step 5) is not needed (there are no spaces around the strings in the final array).
Instead, A; to insert the final semicolon should be added as the last step.

@nik-rev
Copy link
Owner

nik-rev commented Jan 11, 2025

And another one in text into array: Adding spaces (step 5) is not needed (there are no spaces around the strings in the final array). Instead, A; to insert the final semicolon should be added as the last step.

Ok, thanks for noticing this. Semicolon was removed and it was auto-inserted by prettier. I have disabled formatting for that file since it isn't useful to have it!

@nik-rev
Copy link
Owner

nik-rev commented Jan 11, 2025

while testing this i found a bug in helix :O helix-editor/helix#12495

@freelon
Copy link
Author

freelon commented Jan 11, 2025

while testing this i found a bug in helix :O helix-editor/helix#12495

Nice catch :D

@nik-rev nik-rev closed this as completed in 919511c Feb 7, 2025
nik-rev added a commit that referenced this issue Feb 7, 2025
fix #3, also fix missing <enter> key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants