Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Tutorials Added: Simulating Illumina Reads and Uploading Data to Cavatica #263

Merged
merged 96 commits into from
Dec 17, 2020

Conversation

abhijna
Copy link
Collaborator

@abhijna abhijna commented Nov 10, 2020

PR Checklist

PR Description

This is a new tutorial about using InSilicoSeq to simulating fastq data from a user-specified version of the human reference genome. It also includes some QC steps to see how the simulation looks. While this tutorial is good for simulating fastq reads from normal human samples, it cannot simulate mutations or indels.

Need someone to run through everything and make sure 1) that 16GB is enough for it all. 2) that it all works. I haven't done the formatting yet. If there are things you notice and can change easily, please do. If not, leave me a comment and I can fix it when I get to it.

Also added the command line uploader tutorial here. Was going to make a new PR but I pushed changes to this branch by mistake. Sorry :(
Same deal for this tutorial as well. Check if everything run, look for typos, formatting problems, other ways to improve it.

Preview link
https://cfde-training-and-engagement--263.com.readthedocs.build/en/263/Bioinformatics-Skills/Simulate_Illumina_Reads/

Review format

Direct editing or comments are ok.

Timeline

This is due for December release. Don't care when you give me detailed comments as long as you give me enough time to incorporate your changes. If you can run through the code and let me know if it all installs on your computer in the next two weeks, that would be helpful.

s-canchi and others added 30 commits October 9, 2020 14:00
@abhijna
Copy link
Collaborator Author

abhijna commented Dec 9, 2020

I made all the changes. Put two of the comments (about md5sum and screencasts) into issues for the next release.

@jeremywalter
Copy link
Contributor

RE: minor edits commit -- I already did that? could create a conflict? leaving this here for reference in case it does (how did that happen?)

@marisalim
Copy link
Contributor

marisalim commented Dec 10, 2020

@abhijna for the Cavatica uploader tutorial:

  • all the steps worked!
  • minor: the cavatica uploader is a ".tgz" file, but the explanation of the tar command talks about "tar.gz" extension. are they the same? ---> yes it is the same. I changed it to say .tgz :)
  • this can be an edit for next iteration, but i think it would be best to stick to 1 example dataset - show the yeast example files in the Cavatica screenshots instead of the sim data ones. ---> yeah, i'd have to redo all the screenshots. so this can be a thing for next time.
  • add a note/link to close down the AWS instance at the end of the tutorial. ---> done

@abhijna
Copy link
Collaborator Author

abhijna commented Dec 11, 2020

Done :)

@marisalim marisalim self-requested a review December 17, 2020 00:34
Copy link
Contributor

@marisalim marisalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like all the changes i requested got added! good to go

@abhijna abhijna self-assigned this Dec 17, 2020
@abhijna abhijna linked an issue Dec 17, 2020 that may be closed by this pull request
@abhijna abhijna merged commit f8ef429 into dev Dec 17, 2020
@abhijna abhijna deleted the abhijna branch December 17, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dec-2020 Website release for December 2020 new Label for PR merges for new tutorials
Projects
None yet
5 participants