Enable editing of preset temp targets #236

dsnallfot · 2024-05-25T07:59:25Z

Enable editing Name, Target and Duration for preset temp targets
Swipe left to edit or delete
Replaced display of "Low target - High target" in presetView since only low target is used
Edit popup shows current settings, and editing of name, target and duration is done in the popup

Connected to issue #234 and PR #235

Extra useful when preset temp targets are used with shortcuts (no need to re add changed presets in shortcuts since id remains unchanged after edit - even if you change name on the preset)

NOTE! This is not an attempt to redesign the entire UI. This is just to add edit functionality with minimal changes.

Screenshots

Edit or Delete swipe	Edit View

Video demo

Simulator.Screen.Recording.-.iPhone.13.mini+.-.2024-05-25.at.09.45.30.mp4

- Enable editing Name, Target and Duration for preset temp targets - Swipe left to edit or delete - Replaced display of "Low target - High target" in presetView since only low target is used

dsnallfot · 2024-05-25T10:07:49Z

Bug: just figured out that md/dl values are saved as decimals instead of integers when editing presets, which causes unwanted decimals in temptargets_presets.json file when mmol is converted to mg/dl and not rounded. Will fix this shortly.

dnzxy · 2024-05-25T10:22:52Z

Please see my comment on #235, the same is applies for the UI of this proposed change.

dsnallfot · 2024-05-25T10:43:17Z

~~Closed since we should wait with all UI/UX changes until after 1.0 release.~~

aug0211 · 2024-05-25T11:47:19Z

I like this UX, it’s more intuitive than the override version (editing in the popup is more natural to other experiences on iOS)

I think swiping is clear enough, better than a long tap! I guess a dedicated “Edit” mode could be added in the top corner; maybe that’s more iOS standard? I like the swipe for options though, personally. I could see additional swipe functionality being added eventually, too, such as “duplicate” to save into a new entry with identical settings as the starting point to modify.

I’m very eager to get people who are ready and able to do UX and UI work unblocked - UI/UX is perhaps the weakest point of Trio currently (maybe behind Caregiver experience) 🙌

dsnallfot · 2024-05-25T11:47:35Z

Reopen and put in the "idea box" until after 1.0 release

…reset

dsnallfot · 2024-05-25T20:35:18Z

The mg/dl decimal rounding bug should be fixed now

dsnallfot · 2024-05-26T08:21:04Z

The same alert after swiping delete logic as in profile overrides PR now also implemented for TTs in this PR

Simulator.Screen.Recording.-.iPhone.13.mini+.-.2024-05-26.at.10.08.55.mp4

avouspierre · 2024-05-26T15:24:57Z

The edit mode doesn't allow to use the experimental approach. Probably not useful as asked in #154

dsnallfot · 2024-05-26T16:00:44Z

The edit mode doesn't allow to use the experimental approach. Probably not useful as asked in #154

Thanks Pierre, Good spotted! You can edit temp targets set by the slider, but only target and duration (no experimental hbt slider in edit mode. That was a compromise I choose to make but didn't communicate clearly in the notes)

But I also noticed when testing right now this that I need to fix the mgdl-mmol conversion for targets set by slider to be able to edit them correctly. Right now only mgdl works as intended. Will fix tonite regardless of what happens with PR 154

dnzxy · 2024-05-26T16:16:34Z

There’s quite a lot of discussion in #154 and I don’t think the slider should be removed but rather fixed (as proposed by @mountrcg ) . In going with that, the slider would need to make a reappearance here for the TT edit view.

dsnallfot · 2024-05-26T16:19:24Z

Ok. Sounds reasonable for consistency. Should be doable

mountrcg · 2024-05-26T16:43:40Z

@dsnallfot can I make a proposal for the slider, which will not be based on changing HBT with slider as currently, but changing the ratio / insulin percentage as also depicted on the slider.
refer to: mountrcg@7974cc2

mountrcg · 2024-05-26T16:54:58Z

What would be great to save HBT in settings instead of pushing it as an extra variable to oref. I don't like this setup as it basically contradicts what is written in a preferences. In prefs currently the 160mg/dL resides and for an adv. TT oref gets a second HBT value that overrides the current setting. Not so good. What do you guys think?

dnzxy · 2024-05-26T17:08:04Z

Please do @mountrcg but in a separate PR. Daniel’s PR here can introduce the editability of presets and slightly change deletion behavior (alert, swipe action), but leaving logic as-is. You can fix / propose a change around the slider either in #154 or in a new PR 😊 let’s please not scopes here.

@dnzxy

- Fix mgdl->mmol rounding when using experimental slider - Also rearrange sliders below % text in experimental view (Reusing @dnzxy ols iAPS PR 321) - Reset all changed values/sliders to 0 if cancelling in edit view . Additional commit regarding experimental slider in edit view upcoming soon in part 2

- Experimental slider now available also in editPresetPopover view - All conversion mgdl/mmol tested and seems to work correct - You can switch between normal and experimental view freely while contemplating your edit - Additional features and UI redesigned excluded from scope

dsnallfot · 2024-05-26T21:57:03Z

Demo with latest (~~last?~~) changes.
Experimental slider now available in edit mode

Video

2024-05-27_01-03-08.mp4

EDIT: ~~Will also fix sliders % populating in edit view based on set targets~~FIxed. Video demo updated

- when entering edit mode. This way you can choose "normal" target/duration entries or use the slider to do your edits

bjornoleh

Tested on a phone, works as expected.

aug0211

Testing on physical device for 24h - looks good!

dnzxy

Tested on simulator device, looks good and works as expected. Very minor comment on a single variable name; I‘m okay with moving forward as-is though 😊

FreeAPS/Sources/Modules/AddTempTarget/AddTempTargetStateModel.swift

Sjoerd-Bo3

Tested this with a live device for several days, edited some TT's during this period. And only found a thing with Experimental Setting, but that was due to my understanding of that. Using it a lot and works great.

dnzxy · 2024-05-30T12:46:46Z

Merging with 4 approvals.

dsnallfot added 2 commits May 25, 2024 09:52

Edit Temp Targets

4b59fa5

- Enable editing Name, Target and Duration for preset temp targets - Swipe left to edit or delete - Replaced display of "Low target - High target" in presetView since only low target is used

Fix "New duration" fit on one line in edit popup

543f817

dsnallfot closed this May 25, 2024

dsnallfot changed the title ~~Enable editing of preset temp targets~~ Enable editing of preset temp targets (Draft to be revisited after 1.0 release) May 25, 2024

dsnallfot reopened this May 25, 2024

dsnallfot added 2 commits May 25, 2024 20:01

Fix rounding issue when converting mmol to mgdl after edit existing p…

b626522

…reset

secondary text color

3136081

ALert after swiping before deletion (same behavior as for overrides)

60e1cfa

dnzxy mentioned this pull request May 26, 2024

Enable editing of preset profile overrides #235

Merged

dsnallfot marked this pull request as ready for review May 26, 2024 10:15

dnzxy changed the title ~~Enable editing of preset temp targets (Draft to be revisited after 1.0 release)~~ Enable editing of preset temp targets May 26, 2024

dnzxy added the enhancement New feature or request label May 26, 2024

dnzxy assigned dsnallfot May 26, 2024

dnzxy requested review from aug0211, avouspierre, dnzxy, bjornoleh and MikePlante1 May 26, 2024 12:35

dnzxy mentioned this pull request May 26, 2024

Override refactor + override in charts + override in Watch #219

Closed

dsnallfot added 2 commits May 26, 2024 22:40

Calculate insulin % based on saved preset target

c6adbda

- when entering edit mode. This way you can choose "normal" target/duration entries or use the slider to do your edits

bjornoleh approved these changes May 27, 2024

View reviewed changes

bjornoleh linked an issue May 27, 2024 that may be closed by this pull request

Allow Editing of Existing Profile Overrides #234

Closed

aug0211 approved these changes May 28, 2024

View reviewed changes

dnzxy mentioned this pull request May 30, 2024

Advanced TempTarget slider #241

Closed

dnzxy approved these changes May 30, 2024

View reviewed changes

FreeAPS/Sources/Modules/AddTempTarget/AddTempTargetStateModel.swift Show resolved Hide resolved

Sjoerd-Bo3 self-requested a review May 30, 2024 12:21

Sjoerd-Bo3 approved these changes May 30, 2024

View reviewed changes

dnzxy merged commit 5310235 into nightscout:dev May 30, 2024
1 check passed

dnzxy mentioned this pull request May 31, 2024

Trio Release 0.2.0 #2

Merged

dsnallfot deleted the dev-edit-tt branch June 16, 2024 12:34

MikePlante1 mentioned this pull request Jun 16, 2024

(Draft) Merge dev into main MikePlante1/Trio#5

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable editing of preset temp targets #236

Enable editing of preset temp targets #236

dsnallfot commented May 25, 2024 •

edited

Loading

dsnallfot commented May 25, 2024 •

edited

Loading

dnzxy commented May 25, 2024

dsnallfot commented May 25, 2024 •

edited

Loading

aug0211 commented May 25, 2024

dsnallfot commented May 25, 2024

dsnallfot commented May 25, 2024

dsnallfot commented May 26, 2024

avouspierre commented May 26, 2024

dsnallfot commented May 26, 2024 •

edited

Loading

dnzxy commented May 26, 2024

dsnallfot commented May 26, 2024

mountrcg commented May 26, 2024

mountrcg commented May 26, 2024

dnzxy commented May 26, 2024

dsnallfot commented May 26, 2024 •

edited

Loading

bjornoleh left a comment

aug0211 left a comment

dnzxy left a comment •

edited

Loading

Sjoerd-Bo3 left a comment

dnzxy commented May 30, 2024

Enable editing of preset temp targets #236

Enable editing of preset temp targets #236

Conversation

dsnallfot commented May 25, 2024 • edited Loading

dsnallfot commented May 25, 2024 • edited Loading

dnzxy commented May 25, 2024

dsnallfot commented May 25, 2024 • edited Loading

aug0211 commented May 25, 2024

dsnallfot commented May 25, 2024

dsnallfot commented May 25, 2024

dsnallfot commented May 26, 2024

avouspierre commented May 26, 2024

dsnallfot commented May 26, 2024 • edited Loading

dnzxy commented May 26, 2024

dsnallfot commented May 26, 2024

mountrcg commented May 26, 2024

mountrcg commented May 26, 2024

dnzxy commented May 26, 2024

dsnallfot commented May 26, 2024 • edited Loading

bjornoleh left a comment

Choose a reason for hiding this comment

aug0211 left a comment

Choose a reason for hiding this comment

dnzxy left a comment • edited Loading

Choose a reason for hiding this comment

Sjoerd-Bo3 left a comment

Choose a reason for hiding this comment

dnzxy commented May 30, 2024

dsnallfot commented May 25, 2024 •

edited

Loading

dsnallfot commented May 25, 2024 •

edited

Loading

dsnallfot commented May 25, 2024 •

edited

Loading

dsnallfot commented May 26, 2024 •

edited

Loading

dsnallfot commented May 26, 2024 •

edited

Loading

dnzxy left a comment •

edited

Loading