Pump/CGM state reverts on phone restart

[dnzxy]

Describe the bug
Upon phone restart, the app seldom reverts to old device state for CGM or pump, thus losing device connection. For pods this inherently leads to loss of device and need for replacement. This looks a lot like an old Loop bug is still present in Trio, but that mustn’t be the case as changes were migrated to FreeAPS and Trio in the past.

Screenshots

Pod error

screenshots by user @Sjoerd-Bo3 showing loss of pod connection and pairing info in bluetooth settings

Setup Information (please complete the following information):

• all pump types
• all CGMs
• Trio version 0.1.0

Additional context
Loop had a very similar issue, if not this issue, and the fix to this issue was moving device state info from UserDefaults to binary file (plist). See LoopKit/Loop#1702

[kskandis]

This looks a lot like an old Loop bug is still present in Trio, but that mustn’t be the case as changes were migrated to FreeAPS and Trio in the past.

It looks like the LoopKit/Loop#1702 fix is not imported to Trio. Trio imports https://github.com/LoopKit/LoopKit but not https://github.com/LoopKit/Loop where the fix to this is implemented. Some of the Trio corresponding code to LoopKit/Loop lives under https://github.com/nightscout/Trio/tree/dev/FreeAPS/Sources/APS, so Loop's fix needs to be merged into Trio's code, such as Loopkit/Loop/Managers/DeviceDataManager.swift,

[dnzxy]

@avouspierre had hinted on Discord that these changes were already imported to FAX and in turn to iAPS, so also Trio. I only recorded the issue here. I also thought this was still present in iAPS/Trio.

Quoting, as of 23/05/2024

I quickly checked but trio (freeaps in fact) seems implemented the plist strategy for the persistent wrapper.. so the fix of loop is probably already here..

If you can take a deeper look at this @kskandis and really compare the plist configs for Trio, please do 🙏

[kskandis]

If you can take a deeper look at this @kskandis and really compare the plist configs for Trio, please do 🙏

Yes, I would have thought, too, but when I looked at your link to the merged PR I saw that it was code in Loop! I will take a deeper look.

[kskandis]

@avouspierre had hinted on Discord that these changes were already imported

Yes, actually his changes are indeed implemented in Trio with [this commit - see FetchGlucoseManager.swift](47fa017) on Mar 17th for CGM and PR #15!

However, pumpManager still uses UserDefaults in DeviceDataManager.swift. So the pumpManager code needs to be updated similar to how CGM was implemented to use PersistentProperty instead of UserDefaults. Also, for existing users, the "legacyPumpManagerRawValue UserDefaults" should be cleared similar to Loop#1702 UserDefaults+Loop and DeviceDataManager.

[dnzxy]

@kskandis I messaged you on Discord last night and sent you a patch file, please check your inbox 😊 I had started that port last night, wasn’t sure if I got through and @aug0211 briefly tested the patch today and it seemed to lose the pod after force quitting the app, so it’s not yet done.

[kskandis]

I messaged you on Discord last night and sent you a patch file

Oh, sorry, I missed your DM. I've read it now. I also made a patch not realizing you did! I will DM you it. It is very similar to yours with some diffs ...

[aug0211]

https://github.com/dnzxy/Trio/tree/pump-loss-fix-migration

Work being done in the above branch

[kskandis]

Should this be closed? I believe it was fixed with #277