Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] handle nil on dashboard info collection #40

Merged
merged 1 commit into from
May 15, 2023
Merged

[FIX] handle nil on dashboard info collection #40

merged 1 commit into from
May 15, 2023

Conversation

nicolastakashi
Copy link
Owner

When getting dashboards without the schema, schemaVersion and timezone property, cole were panic with nil issues.

ArthurSens
ArthurSens approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests :)

@nicolastakashi nicolastakashi force-pushed the fix/nil-handler-dashboard-info branch from 1bbeb7a to dc2e94c Compare May 15, 2023 12:18
@nicolastakashi nicolastakashi force-pushed the fix/nil-handler-dashboard-info branch from dc2e94c to dae3175 Compare May 15, 2023 12:23
@nicolastakashi nicolastakashi merged commit eb80fe5 into main May 15, 2023
@nicolastakashi nicolastakashi deleted the fix/nil-handler-dashboard-info branch May 15, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSens ArthurSens ArthurSens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolastakashi @ArthurSens