Use constructor for modifiers

nickschot · Feb 24, 2025 · 42294f5 · 42294f5
1 parent 25675e9
commit 42294f5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/ember-mobile-menu/src/components/mobile-menu.gjs b/ember-mobile-menu/src/components/mobile-menu.gjs
@@ -22,13 +22,16 @@ class MobileMenuModifier extends Modifier {
   isOpen;
   type;
 
+  constructor() {
+    super(...arguments);
+    registerDestructor(this, cleanup);
+  }
+
   modify(element, _, { register, openOrClose, close, type, isOpen }) {
     if (!this.element) {
       this.element = element;
       this.isOpen = isOpen;
 
-      registerDestructor(this, cleanup);
-
       Promise.resolve().then(() => {
         register();
         openOrClose(isOpen, false);

diff --git a/ember-mobile-menu/src/components/mobile-menu/tray.gjs b/ember-mobile-menu/src/components/mobile-menu/tray.gjs
@@ -23,10 +23,14 @@ class TrayModifier extends Modifier {
   toggleBodyScroll;
   isClosed;
 
+  constructor() {
+    super(...arguments);
+    registerDestructor(this, cleanup);
+  }
+
   modify(element, [toggleBodyScroll, isClosed]) {
     if (!this.element) {
       this.element = element;
-      registerDestructor(this, cleanup);
     }
 
     this.toggleBodyScroll = toggleBodyScroll;