Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-23] New is_it field and update logic #24

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

nickatnight
Copy link
Owner

  • add decorator
  • add new is_it field
  • move repo tests to service
  • update logic

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #24 (01cccca) into main (85cdd60) will decrease coverage by 1.53%.
The diff coverage is 20.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   65.00%   63.47%   -1.53%     
==========================================
  Files          41       42       +1     
  Lines         880      898      +18     
==========================================
- Hits          572      570       -2     
- Misses        308      328      +20     
Flag Coverage Δ
unittests 63.47% <20.00%> (-1.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/src/core/const.py 100.00% <ø> (ø)
backend/src/core/decorators.py 0.00% <0.00%> (ø)
backend/src/services/stream/inbox.py 0.00% <0.00%> (ø)
backend/src/services/tag.py 0.00% <0.00%> (ø)
backend/src/services/game.py 78.94% <33.33%> (-4.39%) ⬇️
backend/src/models/player.py 95.45% <100.00%> (+0.21%) ⬆️
backend/src/repositories/sqlalchemy.py 76.71% <100.00%> (ø)
backend/src/services/player.py 97.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nickatnight nickatnight merged commit 2709744 into main Mar 10, 2023
@nickatnight nickatnight deleted the nickatnight-GH-23 branch March 10, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants