Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle none values and column grouping in results/steps dataframe utility #119

Merged
merged 14 commits into from
Mar 25, 2025

Conversation

vignesh261201
Copy link
Contributor

@vignesh261201 vignesh261201 commented Mar 21, 2025

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

  1. Removed empty measurement columns when storing the steps DataFrame.
  2. Included input columns while grouping.
  3. Removed the status column from the DataFrame when all values are None.

Why should this Pull Request be merged?

To resolve minor bugs.

What testing has been done?

  1. Added a test case to test the empty measurement scenario.
  2. Input column grouping - Covered in the existing test cases.
  3. None value for status column - Updated the existing test

Vigneshwaran-Selvaraj_adi added 10 commits March 20, 2025 19:23
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
@vignesh261201 vignesh261201 changed the title fix: Minor bug fixes in Steps/Result dataframe fix: Handle none values and column grouping in results/steps dataframe utility Mar 21, 2025
Vigneshwaran-Selvaraj_adi added 3 commits March 21, 2025 18:27
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
Signed-off-by: Vigneshwaran-Selvaraj_adi <[email protected]>
@vignesh261201 vignesh261201 marked this pull request as ready for review March 21, 2025 13:43
@vignesh261201 vignesh261201 reopened this Mar 25, 2025
@SSSantosh18 SSSantosh18 merged commit 9eb2087 into ni:master Mar 25, 2025
23 checks passed
@vignesh261201 vignesh261201 deleted the user/vignesh/bug_fix_2 branch March 25, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants