Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example app for NI Tech Demo + extend text-field to support password mode #42

Merged
merged 7 commits into from
Jul 28, 2021

Conversation

scotia673
Copy link
Contributor

@scotia673 scotia673 commented Jul 26, 2021

Pull Request

🤨 Rationale

This change updates the example app to take the form of a simple non-functional login page, that looks like this:

Screen Shot 2021-07-23 at 9 41 01 AM

And dark mode looks like this:

Screen Shot 2021-07-23 at 9 42 06 AM

@haworthia , for some reason the default button style doesn't appear to take on the "outline" state, as you can see in the screenshots. I couldn't get it to take on the correct appearance even by attempting to add the appearance attribute as an attribute on the Angular wrapper. Do you have any idea what I might be missing? If you're not sure, I can create an issue for us to track that separately.

👩‍💻 Implementation

  • Updated the example app template + styling
  • Updated the Angular wrapper for the text-field to support the type attribute

🧪 Testing

Manual validation of changes in the example app.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@scotia673 scotia673 requested review from rajsite and haworthia July 26, 2021 14:56
@haworthia
Copy link
Contributor

@haworthia , for some reason the default button style doesn't appear to take on the "outline" state, as you can see in the screenshots. I couldn't get it to take on the correct appearance even by attempting to add the appearance attribute as an attribute on the Angular wrapper. Do you have any idea what I might be missing? If you're not sure, I can create an issue for us to track that separately.

Based on what you're seeing, it looks like the behaviors aren't coming through into the Angular app. 😢

@scotia673
Copy link
Contributor Author

@haworthia , for some reason the default button style doesn't appear to take on the "outline" state, as you can see in the screenshots. I couldn't get it to take on the correct appearance even by attempting to add the appearance attribute as an attribute on the Angular wrapper. Do you have any idea what I might be missing? If you're not sure, I can create an issue for us to track that separately.

Based on what you're seeing, it looks like the behaviors aren't coming through into the Angular app. 😢

Thanks for taking a look. Milan and I looked earlier today as well and came to the same conclusion. I created an issue so we can track this issue separately. Let me know how I can help!

@scotia673 scotia673 requested a review from rajsite July 27, 2021 20:56
@scotia673 scotia673 merged commit cbce4a9 into main Jul 28, 2021
@scotia673 scotia673 deleted the ni-tech-demo branch July 28, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants