Checkboxes - none of these JS behaviour #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th different input names within a single group
andymantell
commented
Jul 27, 2021
|
@tomdoughty @chrimesdev I think this is ready for review now. Just about to do some browser testing but I think it's complete otherwise - happy to jump on a call and discuss if that is easiest - it might be good to highlight some places where I have had to deviate from the govuk-frontend implementation |
chrimesdev
reviewed
Jul 28, 2021
chrimesdev
reviewed
Jul 28, 2021
chrimesdev
reviewed
Jul 28, 2021
|
Cheers Andy! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add JavaScript behaviour to a set of checkboxes which unsets other checkboxes in a given group when the "None" option is checked, as in the gif below:
Also Fixes #609
Checklist
(Tested in all except Samsung internet as browserstack wasn't working for it)