[refs #416] Extend the page layout to include a fluid-width container. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current nhsuk-width-container is restricted to a max width of 960px. A new container has been added (nhsuk-width-container-fluid), which which spans the entire width of the viewport and allows for full screen layouts.
chrimesdev
force-pushed
the
feature/fluid-container
branch
from
d34f0ae to
b0ec921
Compare
|
@davidhunter08 can you check the spacing of the guttering? It's 16px same as the guttering on the normal container, but not sure if its too tight to the edge. |
|
Am happy with code. Personally I'd prefer 32px guttering when going full width, but happy to hear what @davidhunter08 thinks. |
Add examples for the fixed-width and fluid-width containers to the Core folder README.
|
I agree with @mcheung-nhs, I think it should be a 32px guttering for |
Have the guttering to go 32px above the desktop breakpoint of 769px.
davidhunter08
approved these changes
Mar 19, 2019
|
Looking good, @AdamChrimes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current nhsuk-width-container is restricted to a max width of 960px. A new container has been added (nhsuk-width-container-fluid), which which spans the entire width of the viewport and allows for full-screen layouts.
To Do:
Just in process of writing up the documentation for the service manual, should be ready before we release 2.10.