Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refs #177] Remove <time> element #381

Merged
merged 1 commit into from
Feb 4, 2019
Merged

[refs #177] Remove <time> element #381

merged 1 commit into from
Feb 4, 2019

Conversation

mcheung-nhs
Copy link
Collaborator

Removed the element around the review dates because it fails
validation without a datetime attribute, which cannot be automatically
generated (yet) from the date value. Even though datetime attribute is
not strictly necessary, this can only be the case if the review date
entered is a valid date or time string, which cannot be guaranteed.

More info here:
https://www.w3.org/TR/2011/WD-html5-author-20110705/the-time-element.html

Description

Checklist

  • SCSS
  • Nunjucks macro
  • A standalone example
  • README/Documentation with HTML snippet
  • Tested against our testing policy (Resolution, Browser & Accessibility)
  • Print stylesheet considered
  • CHANGELOG entry

Removed the <time> element around the review dates because it fails
validation without a datetime attribute, which cannot be automatically
generated (yet) from the date value. Even though datetime attribute is
not strictly necessary, this can only be the case if the review date
entered is a valid date or time string, which cannot be guaranteed.

More info here:
https://www.w3.org/TR/2011/WD-html5-author-20110705/the-time-element.html
Copy link
Member

@chrimesdev chrimesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrimesdev chrimesdev merged commit de9c57b into master Feb 4, 2019
@chrimesdev chrimesdev deleted the fix/review-date branch February 4, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants