Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panel component #1012

Merged
merged 21 commits into from
Feb 13, 2025
Merged

Add panel component #1012

merged 21 commits into from
Feb 13, 2025

Conversation

davidhunter08
Copy link
Contributor

@davidhunter08 davidhunter08 commented Sep 10, 2024

Description

Add panel component for use on confirmation pages.

Large screens

Screenshot 2024-09-12 at 14 19 35

Small screens

Screenshot 2024-09-12 at 14 19 51

Checklist

@edwardhorsford
Copy link
Contributor

@davidhunter08 can you add some screenshots?

@davidhunter08
Copy link
Contributor Author

Font sizes

After reviewing the panel font sizes, taking into consideration the proposed type scale updates, I've change the panel body font size to 24px(20px on mobile).

panel-font-sizes

@davidhunter08 davidhunter08 marked this pull request as ready for review November 22, 2024 14:57
@anandamaryon1
Copy link
Collaborator

@davidhunter08 Thoughts on padding? I can see this totals 40px with the border and padding. Our cards tend to have 32px padding. I wonder whether this should have the same padding amount as cards? Possibly not an issue since they shouldn't ever appear on the same page. But worth considering?

Side note, any idea why the panel includes a 4px border? I assume for print/high-contrast styles?

@davidhunter08
Copy link
Contributor Author

@davidhunter08 Thoughts on padding? I can see this totals 40px with the border and padding. Our cards tend to have 32px padding. I wonder whether this should have the same padding amount as cards? Possibly not an issue since they shouldn't ever appear on the same page. But worth considering?

It makes sense and looks ok having the padding 32px.

32px 40px
32px 40px

Side note, any idea why the panel includes a 4px border? I assume for print/high-contrast styles?

I presumed this was for changed/forced colours, same as the buttons, but I haven't tested it. We can test in the accessibility lab.

@anandamaryon1
Copy link
Collaborator

Tested on Windows with high contrast, 4px transparent border shows white 👍
image

frankieroberto
frankieroberto previously approved these changes Jan 21, 2025
Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left some minor suggestions.

I also tested it locally without the body as I don’t think that’ll always be needed, and looks good.

Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
frankieroberto
frankieroberto previously approved these changes Jan 27, 2025
anandamaryon1
anandamaryon1 previously approved these changes Jan 30, 2025
frankieroberto
frankieroberto previously approved these changes Jan 30, 2025
@anandamaryon1 anandamaryon1 dismissed stale reviews from frankieroberto and themself via c86494a February 3, 2025 16:45
@anandamaryon1 anandamaryon1 self-requested a review February 3, 2025 17:10
anandamaryon1
anandamaryon1 previously approved these changes Feb 3, 2025
frankieroberto
frankieroberto previously approved these changes Feb 5, 2025
@anandamaryon1 anandamaryon1 dismissed stale reviews from frankieroberto and themself via 4230cd5 February 13, 2025 09:13
@anandamaryon1 anandamaryon1 self-requested a review February 13, 2025 09:23
anandamaryon1
anandamaryon1 previously approved these changes Feb 13, 2025
@anandamaryon1 anandamaryon1 merged commit 7b657d2 into main Feb 13, 2025
5 checks passed
@anandamaryon1 anandamaryon1 deleted the confirmation-panel branch February 13, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants