-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary Component - vertical alignment #663
Comments
Hey @SatnamSinghUK thanks for opening this issue. This seems like a viable fix to the issue, do you want to open a pull request on the NHS.UK frontend repository with your proposed changes? The team can then review the changes and take this forward. If you're not sure where to start we have the NHS.UK frontend contributing guidelines. Thanks |
I have transferred this issue to the NHS.UK frontend repository as it relates to an issue with code in the library. |
Hey Adam, Thanks for the quick response on this. Fantastic I will push the fix on that repo 👍 |
Thanks for that @SatnamSinghUK I will take a look tomorrow and get it merged. |
Hi, I have an issue with the Summary Component.
All text aligns to the top fine.
But adding an image/map forces the Title and Change link to align to the bottom
What
Why
Here a repro of the issue
https://jsfiddle.net/qc2tayw6/
I think this is a viable issue, if in a scenario where an image or a map or similar needs to be added, all the elements should align correctly.
Anything else
A proposed fix is adding something like this:
.nhsuk-summary-list__key,
.nhsuk-summary-list__value,
.nhsuk-summary-list__actions {
vertical-align: top;
}
So all elements align vertically to the top
The text was updated successfully, but these errors were encountered: