Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header search query doesn't submit with enter key. #522

Closed
sab-h opened this issue Sep 2, 2019 · 2 comments
Closed

Header search query doesn't submit with enter key. #522

sab-h opened this issue Sep 2, 2019 · 2 comments
Assignees
@sab-h
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕙 hours A well understood issue which we expect to take less than a day to resolve

Comments

@sab-h
Copy link
Contributor

sab-h commented Sep 2, 2019 •
edited by chrimesdev
Loading

What is the issue?

Pressing enter after entering a search term doesn't do anything.

Pressing Return should give results from both search bars (main search bar and search results page), currently only clicking the magnifying glass icon returns results.

This is not helpful for keyboard accessibility and we observed many users hitting Return and no action taking place.
@sab-h sab-h self-assigned this Sep 2, 2019
sab-h pushed a commit that referenced this issue Sep 2, 2019
[refs #522] search enter key fix
c526040
sab-h pushed a commit that referenced this issue Sep 2, 2019
[refs #522] search enter key fix
33ef502 
[refs #522] search enter key fix

[refs #522] search enter key fix
sab-h pushed a commit that referenced this issue Sep 2, 2019
[refs #522] search enter key fix
396d36d 
[refs #522] search enter key fix

[refs #522] search enter key fix

[refs #522] search enter key fix

[refs #522] search enter key fix
@sab-h sab-h mentioned this issue Sep 2, 2019
Merged
3 tasks
sab-h pushed a commit that referenced this issue Sep 2, 2019
[refs #522] search enter key fix
f5d86e6 
[refs #522] search enter key fix

[refs #522] search enter key fix

[refs #522] search enter key fix

[refs #522] search enter key fix

[refs #522] search enter key fix
chrimesdev pushed a commit that referenced this issue Sep 5, 2019
@chrimesdev
[refs #522] handle the enter keydown event to perform search
f408467
chrimesdev pushed a commit that referenced this issue Sep 5, 2019
@chrimesdev
[refs #522] handle the enter keydown event to perform search
6d2aa84
chrimesdev pushed a commit that referenced this issue Sep 5, 2019
@chrimesdev
[refs #522] handle the enter keydown event to perform search
e5998ac
chrimesdev pushed a commit that referenced this issue Sep 5, 2019
@chrimesdev
[refs #522] handle the enter keydown event to perform search
6447268
chrimesdev pushed a commit that referenced this issue Sep 5, 2019
@chrimesdev
[refs #522] handle the enter keydown event to perform search
099c48b
chrimesdev pushed a commit that referenced this issue Sep 5, 2019
@chrimesdev
[refs #522] handle the enter keydown event to perform search
d0ab84f
chrimesdev added a commit that referenced this issue Sep 5, 2019
@chrimesdev
Merge pull request #523 from nhsuk/search-enter-fix
15855e0 
[refs #522] search enter key fix
@chrimesdev
Copy link
Member

chrimesdev commented Sep 5, 2019 •
edited
Loading

This is fixed and will be released in v2.3.1

@chrimesdev chrimesdev added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕙 hours A well understood issue which we expect to take less than a day to resolve Priority: low labels Sep 5, 2019
@chrimesdev chrimesdev changed the title Search query doesn't submit with enter key. Header search query doesn't submit with enter key. Sep 9, 2019
@chrimesdev
Copy link
Member

This has been released in v2.3.1.

Thanks @Sabi98 for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sab-h sab-h

Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕙 hours A well understood issue which we expect to take less than a day to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrimesdev @sab-h