Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading spacing after details / expander component #486

Closed
davidhunter08 opened this issue Jul 3, 2019 · 2 comments
Closed

Heading spacing after details / expander component #486

davidhunter08 opened this issue Jul 3, 2019 · 2 comments
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) good first issue Good for newcomers

Comments

@davidhunter08
Copy link
Contributor

Bug Report

What is the issue?

The spacing between a details component and a h2 / nhsuk-heading-l isn't right. The h2 / nhsuk-heading-l needs padding-top adding.

Similar to how it works for paragraphs:

%nhsuk-body-m  + %nhsuk-heading-l,
%nhsuk-body-s  + %nhsuk-heading-l,
%nhsuk-list + %nhsuk-heading-l {
  @include nhsuk-responsive-padding(4, 'top');
}

What steps are required to reproduce the issue?

Add a details component to a page, followed by a h2.

You will see that there is no padding-top applied to the h2.

Screenshot 2019-07-03 at 17 02 12

It should look like this:

Screenshot 2019-07-03 at 17 02 27

@davidhunter08 davidhunter08 added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) Style labels Jul 3, 2019
@chrimesdev chrimesdev removed the Style label Jul 9, 2019
@chrimesdev
Copy link
Member

The code for this fix is in the NHS digital service manual: https://github.com/nhsuk/nhsuk-service-manual/blob/develop/app/styles/main.scss#L60

@chrimesdev chrimesdev added the good first issue Good for newcomers label Jul 9, 2019
Lily418 pushed a commit to Lily418/nhsuk-frontend that referenced this issue Jul 18, 2019
Lily418 pushed a commit to Lily418/nhsuk-frontend that referenced this issue Jul 18, 2019
Lily418 pushed a commit to Lily418/nhsuk-frontend that referenced this issue Jul 22, 2019
Lily418 pushed a commit to Lily418/nhsuk-frontend that referenced this issue Jul 22, 2019
Lily418 pushed a commit to Lily418/nhsuk-frontend that referenced this issue Jul 22, 2019
Lily418 pushed a commit to Lily418/nhsuk-frontend that referenced this issue Jul 22, 2019
Lily418 pushed a commit to Lily418/nhsuk-frontend that referenced this issue Jul 22, 2019
davidhunter08 pushed a commit that referenced this issue Jul 23, 2019
* [ref #486] A h2 / nhsuk-heading-l needs additional padding top after a details component

* Add changelog entry for issue [ref #486]
@chrimesdev
Copy link
Member

Fixed in v2.3.0.

Thanks @Lily418 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants