-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heading spacing after details / expander component #486
Labels
🐛 bug
Something isn't working the way it should (including incorrect wording in documentation)
good first issue
Good for newcomers
Comments
The code for this fix is in the NHS digital service manual: https://github.com/nhsuk/nhsuk-service-manual/blob/develop/app/styles/main.scss#L60 |
Lily418
pushed a commit
to Lily418/nhsuk-frontend
that referenced
this issue
Jul 18, 2019
Lily418
pushed a commit
to Lily418/nhsuk-frontend
that referenced
this issue
Jul 18, 2019
…fter a details component
3 tasks
Lily418
pushed a commit
to Lily418/nhsuk-frontend
that referenced
this issue
Jul 22, 2019
Lily418
pushed a commit
to Lily418/nhsuk-frontend
that referenced
this issue
Jul 22, 2019
…fter a details component
Lily418
pushed a commit
to Lily418/nhsuk-frontend
that referenced
this issue
Jul 22, 2019
Lily418
pushed a commit
to Lily418/nhsuk-frontend
that referenced
this issue
Jul 22, 2019
…fter a details component
Lily418
pushed a commit
to Lily418/nhsuk-frontend
that referenced
this issue
Jul 22, 2019
davidhunter08
pushed a commit
that referenced
this issue
Jul 23, 2019
Fixed in v2.3.0. Thanks @Lily418 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐛 bug
Something isn't working the way it should (including incorrect wording in documentation)
good first issue
Good for newcomers
Bug Report
What is the issue?
The spacing between a
details
component and ah2
/nhsuk-heading-l
isn't right. Theh2
/nhsuk-heading-l
needspadding-top
adding.Similar to how it works for paragraphs:
What steps are required to reproduce the issue?
Add a
details
component to a page, followed by ah2
.You will see that there is no
padding-top
applied to theh2
.It should look like this:
The text was updated successfully, but these errors were encountered: