Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header: Autocomplete dropdown #484

Closed
sab-h opened this issue Jun 27, 2019 · 2 comments · Fixed by #517
Closed

Header: Autocomplete dropdown #484

sab-h opened this issue Jun 27, 2019 · 2 comments · Fixed by #517
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕙 days A few unknowns, but we roughly know what’s involved help wanted Extra attention is needed

Comments

@sab-h
Copy link
Contributor

sab-h commented Jun 27, 2019

Bug Report

What is the issue?

The autocomplete dropdown moves as you scroll down.

What steps are required to reproduce the issue?

Go on NHS.uk and type headache and scroll down whilst the dropdown is open.

Is there anything else you think would be useful in recreating the issue?

image
@sab-h sab-h changed the title Autocomplete dropdown not 'fixed' Autocomplete dropdown Jun 27, 2019
@chrimesdev
Copy link
Member

chrimesdev commented Jul 3, 2019 •
edited
Loading

You going to give this fix a go @Sabi98?

@chrimesdev chrimesdev added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Jul 9, 2019
@chrimesdev chrimesdev added 🕙 days A few unknowns, but we roughly know what’s involved help wanted Extra attention is needed Priority: low labels Jul 23, 2019
@chrimesdev chrimesdev changed the title Autocomplete dropdown Header: Autocomplete dropdown Aug 14, 2019
@sab-h sab-h mentioned this issue Aug 21, 2019
Merged
sab-h pushed a commit that referenced this issue Aug 21, 2019
[refs #484] search drop-down fix
41edf4a 
fix syntax
chrimesdev pushed a commit that referenced this issue Aug 27, 2019
@chrimesdev
[refs #484] search drop-down fix
d11a5a4 
fix syntax
chrimesdev pushed a commit that referenced this issue Sep 5, 2019
@chrimesdev
[refs #484] search drop-down fix
dfe00e9 
fix syntax
@chrimesdev
Copy link
Member

This has been released in v2.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕙 days A few unknowns, but we roughly know what’s involved help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

search drop-down fix nhsuk/nhsuk-frontend
2 participants
@chrimesdev @sab-h