Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Care Card (immediate) - Details component text colour #475

Closed
davidhunter08 opened this issue Jun 24, 2019 · 2 comments
Closed

Care Card (immediate) - Details component text colour #475

davidhunter08 opened this issue Jun 24, 2019 · 2 comments
Labels
accessibility Accessibility related 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) good first issue Good for newcomers

Comments

@davidhunter08
Copy link
Contributor

davidhunter08 commented Jun 24, 2019 •
edited
Loading

What is the issue?

The text colour of the details component does not have sufficient colour contrast when used in a Care Card - Immediate.

Screenshot 2019-06-24 at 10 52 27

Solution

.nhsuk-care-card--immediate {

  .nhsuk-details,
  .nhsuk-details__summary {
    color: $color_nhsuk-white;
  }

  .nhsuk-details__summary {
    &:hover,
    &:focus {
      color: $color_nhsuk-black;
    }
  }

}
@davidhunter08 davidhunter08 added accessibility Accessibility related 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) component labels Jun 24, 2019
@chrimesdev chrimesdev added the good first issue Good for newcomers label Jul 9, 2019
@chrimesdev
Copy link
Member

Screenshot 2019-07-11 at 10 36 22

chrimesdev added a commit that referenced this issue Jul 11, 2019
@chrimesdev
[refs #475] colour contrast issue when using the Details component wi…
89ddcb9 
…thin Care card

Fix colour contrast issue when using the Details component within the
Care card (immediate) #475
@chrimesdev chrimesdev mentioned this issue Jul 11, 2019
Merged
8 tasks
chrimesdev added a commit that referenced this issue Jul 15, 2019
@chrimesdev
[refs #475] colour contrast issue when using the Details component wi…
5eb219e 
…thin Care card

Fix colour contrast issue when using the Details component within the
Care card (immediate) #475
@chrimesdev
Copy link
Member

Fixed in v2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Accessibility related 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrimesdev @davidhunter08