Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button component :focus state #406

Closed
davidhunter08 opened this issue Feb 25, 2019 · 1 comment
Closed

Button component :focus state #406

davidhunter08 opened this issue Feb 25, 2019 · 1 comment

Comments

@davidhunter08
Copy link
Contributor

Bug Report

What is the issue?

The button component does not display the 4px border on :focus.
davidhunter08 added a commit that referenced this issue Feb 25, 2019
@davidhunter08
[refs #406] Button component :focus state
817abd6 
- A fix for the :focus state to display a 4px yellow border
- Bumped version - 1.1.0
- Updated CHANGELOG.md
chrimesdev pushed a commit that referenced this issue Feb 27, 2019
@davidhunter08 @chrimesdev
[refs #406] Button component :focus state
13751bc 
- A fix for the :focus state to display a 4px yellow border
- Bumped version - 1.1.0
- Updated CHANGELOG.md
chrimesdev added a commit that referenced this issue Feb 27, 2019
@chrimesdev
[refs #406] Visual regression tests for button click and focus styling
55a778e
chrimesdev pushed a commit that referenced this issue Feb 27, 2019
@davidhunter08 @chrimesdev
[refs #406] Button component :focus state
293b1ce 
- A fix for the :focus state to display a 4px yellow border
- Bumped version - 1.1.0
- Updated CHANGELOG.md
chrimesdev added a commit that referenced this issue Feb 27, 2019
@chrimesdev
[refs #406] Visual regression tests for button click and focus styling
6035b32
chrimesdev pushed a commit that referenced this issue Feb 27, 2019
@davidhunter08 @chrimesdev
[refs #406] Button component :focus state
bbb27e6 
- A fix for the :focus state to display a 4px yellow border
- Bumped version - 1.1.0
- Updated CHANGELOG.md
chrimesdev added a commit that referenced this issue Feb 27, 2019
@chrimesdev
[refs #406] Visual regression tests for button click and focus styling
82e89a9
mcheung-nhs pushed a commit that referenced this issue Feb 27, 2019
@davidhunter08 @mcheung-nhs
[refs #406] Button component :focus state
1037227 
- A fix for the :focus state to display a 4px yellow border
- Bumped version - 1.1.0
- Updated CHANGELOG.md
mcheung-nhs pushed a commit that referenced this issue Feb 27, 2019
@chrimesdev @mcheung-nhs
[refs #406] Visual regression tests for button click and focus styling
c34be72
mcheung-nhs added a commit that referenced this issue Feb 27, 2019
@mcheung-nhs
Merge pull request #407 from nhsuk/bug/button-focus
4cda8fd 
[refs #406] Button component :focus state
@mcheung-nhs
Copy link
Collaborator

Done and merged: #407
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcheung-nhs @davidhunter08