-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with NHS.UK Homepage header (relating to the hero component) #400
Comments
mcheung-nhs
added a commit
that referenced
this issue
Mar 7, 2019
Refactor positioning of the content on the hero component so that it is not positioned absolutely in smaller screen sizes. This lets the text flow naturally when increasing font size or text spacing.
mcheung-nhs
added a commit
that referenced
this issue
Mar 7, 2019
Reduced bottom margin of the hero content, and added the changed reference backstop images.
mcheung-nhs
added a commit
that referenced
this issue
Mar 8, 2019
mcheung-nhs
added a commit
that referenced
this issue
Mar 8, 2019
chrimesdev
pushed a commit
that referenced
this issue
Mar 11, 2019
Refactor positioning of the content on the hero component so that it is not positioned absolutely in smaller screen sizes. This lets the text flow naturally when increasing font size or text spacing.
chrimesdev
pushed a commit
that referenced
this issue
Mar 11, 2019
Reduced bottom margin of the hero content, and added the changed reference backstop images.
chrimesdev
pushed a commit
that referenced
this issue
Mar 11, 2019
chrimesdev
pushed a commit
that referenced
this issue
Mar 11, 2019
This has been fixed and released in version 2.0.0 of nhsuk-frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spotted this issue in the lab - using Firefox, zooming in 300x or 400x and applying some additional text spacing (to simulate fonts used by some dyslexic users).
It created an overlapping issue in the header.
The easiest way (assuming you don’t have CSP on the server) is a bookmarklet:
https://www.html5accessibility.com/tests/tsbookmarklet.html
If that doesn’t work, or you want to keep that styling applied is to use the Stylus pluggin:
https://chrome.google.com/webstore/detail/stylus/clngdbkpkpeebahjckkjfobafhncgmne?hl=en
https://addons.mozilla.org/en-US/firefox/addon/styl-us/
With the following CSS added:
line-height: 1.5 !important;
letter-spacing: 0.12em !important;
word-spacing: 0.16em !important;
}
p {
margin-bottom: 2em;
}
Interestingly (or annoyingly from the team’s point of view) it depends how the over-ride is done.
With the bookmarklet:

With the pluggin:

I think it is because the bookmarklet is slightly better at over-riding the site’s CSS, so the line-height is being applied properly.
The text was updated successfully, but these errors were encountered: