Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the jQuery dependency requirement #320

Closed
chrimesdev opened this issue Dec 24, 2018 · 1 comment
Closed

Remove the jQuery dependency requirement #320

chrimesdev opened this issue Dec 24, 2018 · 1 comment

Comments

@chrimesdev
Copy link
Member

chrimesdev commented Dec 24, 2018 •
edited
Loading

The Header component search autocomplete uses Typeahead which requires jQuery, this has been used on the live NHS.UK website for a while. This is the only component within the Frontend library that requires jQuery, and we want to move away from using jQuery, mainly for performance improvements by not having to load in a (large) third party library.

Research and development has started into using the GOV.UK accessible autocomplete so that we can remove the Typeahead script.
chrimesdev added a commit that referenced this issue Jan 2, 2019
@chrimesdev
[refs #320] Remove jQuery and typeahead dependencies
937317b 
In preparation for moving away from jQuery and typeahead and using the
GOV.UK autocomplete, remote the jQuery and typeahead dependencies and
configurations.
chrimesdev added a commit that referenced this issue Jan 2, 2019
@chrimesdev
[refs #320] Initial setup and styling for autocomplete
7ab0203 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
chrimesdev added a commit that referenced this issue Jan 2, 2019
@chrimesdev
[refs #320] Initial setup and styling for autocomplete
869bde3 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
chrimesdev added a commit that referenced this issue Jan 2, 2019
@chrimesdev
[refs #320] Initial setup and styling for autocomplete
c44286f 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
chrimesdev added a commit that referenced this issue Jan 2, 2019
@chrimesdev
[refs #320] Initial setup and styling for autocomplete
d875dfe 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
chrimesdev added a commit that referenced this issue Jan 2, 2019
@chrimesdev
[refs #320] Initial setup and styling for autocomplete
c0ee313 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
chrimesdev added a commit that referenced this issue Jan 2, 2019
@chrimesdev
[refs #320] Initial setup and styling for autocomplete
dfe5f79 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
chrimesdev added a commit that referenced this issue Jan 2, 2019
@chrimesdev
[refs #320] Initial setup and styling for autocomplete
da1c632 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
chrimesdev added a commit that referenced this issue Jan 2, 2019
@chrimesdev
[refs #320] Initial setup and styling for autocomplete
022b0e3 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
davidhunter08 added a commit that referenced this issue Jan 4, 2019
@davidhunter08
[refs #320] Search autocomplete styling
97b50db 
Updated styling for the search autocomplete on desktop and mobile.
Added styling for both`:hover` and `:focus` states.
Removed borders and border radius from `autocomplete_menu`.
Fixed issue on mobile by adding `width: 100%`
to `autocomplete_menu`.
davidhunter08 pushed a commit that referenced this issue Jan 4, 2019
@chrimesdev @davidhunter08
[refs #320] Remove jQuery and typeahead dependencies
6abeb15 
In preparation for moving away from jQuery and typeahead and using the
GOV.UK autocomplete, remote the jQuery and typeahead dependencies and
configurations.
davidhunter08 pushed a commit that referenced this issue Jan 4, 2019
@chrimesdev @davidhunter08
[refs #320] Initial setup and styling for autocomplete
cc43736 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
davidhunter08 added a commit that referenced this issue Jan 4, 2019
@davidhunter08
[refs #320] Search autocomplete styling
b9275d6 
Updated styling for the search autocomplete on desktop and mobile.
Added styling for both`:hover` and `:focus` states.
Removed borders and border radius from `autocomplete_menu`.
Fixed issue on mobile by adding `width: 100%`
to `autocomplete_menu`.
chrimesdev pushed a commit that referenced this issue Jan 8, 2019
@chrimesdev
[refs #320] Fixed autocomplete dropdown onclick event
d0abb6b 
The links in the dropdown were not linking to their relevant
page, this has now been fixed. Also corrected some spelling mistakes
within the JavaScript functions.
chrimesdev pushed a commit that referenced this issue Jan 8, 2019
@chrimesdev
[refs #320] Cursor pointer for links and remove whitespaces
c70ab03
mcheung-nhs added a commit that referenced this issue Jan 11, 2019
@mcheung-nhs
[refs #320] Tidy up autocomplete - js and styling
0823945 
Added existing styling to autocomplete so looks similar to what is live.
Amended js to add search icon and 'Search suggestions' title, but there
is an issue with it not being created in the right place so this will be
looked at.
mcheung-nhs added a commit that referenced this issue Jan 15, 2019
@mcheung-nhs
[refs #320] Remove search suggestions heading
98b6b1c 
It is not currently possible to have the search suggestions heading at
the top of the dropdown list so this has been removed.

Fixed an IE<=11 issue with '.remove()' not supported.

Removed the bolding of the typed text because VoiceOver pronounced the
search suggestion in a funny way. For example, if you start typing 'he'
the results may include 'health', 'behind the headlines', 'heart'. These
would be pronounced as
'he' 'alth',
'behind t' 'he' 'he' 'adlines'
'he' 'art'
which sounds weird and not really acceptable.
mcheung-nhs pushed a commit that referenced this issue Jan 15, 2019
@chrimesdev @mcheung-nhs
[refs #320] Remove jQuery and typeahead dependencies
3274041 
In preparation for moving away from jQuery and typeahead and using the
GOV.UK autocomplete, remote the jQuery and typeahead dependencies and
configurations.
mcheung-nhs pushed a commit that referenced this issue Jan 15, 2019
@chrimesdev @mcheung-nhs
[refs #320] Initial setup and styling for autocomplete
348c0b7 
Add the GOV.UK autocomplete dependency connected to the NHS.UK
funnelback search autocomplete. Also add some default styling
for the autocomplete dropdown that needs finishing.
mcheung-nhs pushed a commit that referenced this issue Jan 15, 2019
@davidhunter08 @mcheung-nhs
[refs #320] Search autocomplete styling
50e5a70 
Updated styling for the search autocomplete on desktop and mobile.
Added styling for both`:hover` and `:focus` states.
Removed borders and border radius from `autocomplete_menu`.
Fixed issue on mobile by adding `width: 100%`
to `autocomplete_menu`.
mcheung-nhs pushed a commit that referenced this issue Jan 15, 2019
@mcheung-nhs
[refs #320] Fixed autocomplete dropdown onclick event
df38aeb 
The links in the dropdown were not linking to their relevant
page, this has now been fixed. Also corrected some spelling mistakes
within the JavaScript functions.
mcheung-nhs pushed a commit that referenced this issue Jan 15, 2019
@mcheung-nhs
[refs #320] Cursor pointer for links and remove whitespaces
ec7ffeb
mcheung-nhs added a commit that referenced this issue Jan 15, 2019
@mcheung-nhs
[refs #320] Tidy up autocomplete - js and styling
1e7ed80 
Added existing styling to autocomplete so looks similar to what is live.
Amended js to add search icon and 'Search suggestions' title, but there
is an issue with it not being created in the right place so this will be
looked at.
mcheung-nhs added a commit that referenced this issue Jan 15, 2019
@mcheung-nhs
[refs #320] Remove search suggestions heading
81991f0 
It is not currently possible to have the search suggestions heading at
the top of the dropdown list so this has been removed.

Fixed an IE<=11 issue with '.remove()' not supported.

Removed the bolding of the typed text because VoiceOver pronounced the
search suggestion in a funny way. For example, if you start typing 'he'
the results may include 'health', 'behind the headlines', 'heart'. These
would be pronounced as
'he' 'alth',
'behind t' 'he' 'he' 'adlines'
'he' 'art'
which sounds weird and not really acceptable.
mcheung-nhs added a commit that referenced this issue Jan 15, 2019
@mcheung-nhs
[refs #320] Remove merge conflict code
963bd0d 
Removed merge messages from previous merge, which was missed.
mcheung-nhs added a commit that referenced this issue Jan 16, 2019
@mcheung-nhs
[refs #320] Fix bug if no search in header, plus make it more efficient
5b97d8f 
Do checks for search divs and elements to run the autocomplete code,
else ignore it it.
mcheung-nhs added a commit that referenced this issue Jan 16, 2019
@mcheung-nhs
[refs #320] Reorder attribute order of <button> element
0805d80 
As per our [coding standards](/docs/contributing/coding-standards.md#html)
mcheung-nhs added a commit that referenced this issue Jan 16, 2019
@mcheung-nhs
[refs #320] Remove TO DO commented lines
1109073 
Removed commented TO DO lines in the defaultConfig.
@mcheung-nhs
Copy link
Collaborator

New autocomplete (minus jQuery) merged in here:
PR 342
so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcheung-nhs @chrimesdev