Skip to content

Commit

Permalink
[refs #588] Action link icon contrast in the immediate Care card
Browse files Browse the repository at this point in the history
Give the Action link icon sufficient contrast when used in the Care card immediate variant
  • Loading branch information
chrimesdev committed Feb 19, 2021
1 parent bd67d4c commit d59e048
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Removing support for IE8-10 and updating the NHS logo SVG html means the `xlink:href` is no longer an issue ([PR 657](https://github.com/nhsuk/nhsuk-frontend/pull/657), [PR 673](https://github.com/nhsuk/nhsuk-frontend/pull/673)). This also fixes the issue of not being able to select or focus on the NHS logo when using VoiceOver on iOS ([PR 631](https://github.com/nhsuk/nhsuk-frontend/pull/631))
- Fix Create release GitHub Action which wasn't publishing to NPM ([Issue 691](https://github.com/nhsuk/nhsuk-frontend/issues/691))
- Modifying the Card JavaScript to reference Card rather than the old Panel and adding Card to the NPM docs.
- Give the Action link icon sufficient contrast when used in the Care card immediate variant ([Issue 588](https://github.com/nhsuk/nhsuk-frontend/issues/588))

:boom: **Breaking changes**

Expand Down
7 changes: 7 additions & 0 deletions packages/components/care-card/_care-card.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* 5. 'Random number' used for spacing to compensate for the triangle.
* 6. Needed to enable the triangle to show correctly in high contrast mode.
* 7. Prevent additional padding on headings
* 8. Give the action link icon sufficient contrast when used in the immediate variant
*/

.nhsuk-care-card {
Expand Down Expand Up @@ -149,4 +150,10 @@
}
}

.nhsuk-action-link__link {
.nhsuk-icon__arrow-right-circle {
fill: $color_nhsuk-white; /* [8] */
}
}

}

0 comments on commit d59e048

Please sign in to comment.