Add parent page to Consent Form journey #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvararu
commented
Sep 5, 2023
| href: session_consent_form_edit_path(@session, @consent_form, :parent), | ||
| visually_hidden_text: "your phone") | ||
| end | ||
| end %> |
There was a problem hiding this comment.
This isn't the exhaustive list; notably the _other stuff isn't visible. I can add it now, or we can come back to it later, the prototype isn't up to date on how this should look in every permutation. I thought not to spend too much time as this is something that we could ship even if it's a bit incomplete.
There was a problem hiding this comment.
Is this something that we'll easily catch in a snagging session, or should we card it up?
There was a problem hiding this comment.
Let's leave it for later...
Update the model, validations, and controller params.
misaka
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #482.
This adds the "About you" parent details page from the prototype. Also updates the Avo resource with the newly added fields.
Screenshot with validation errors
Confirmation page