Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minute set to non-selectable minutes when changing selectable range #89

Merged
merged 7 commits into from
Jan 3, 2023

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Fixed an issue that the selected time was set to an unselectable time when the selected time was changed due to the range setting.
    • The time was set one minute earlier than the selectable range.
    • Also, when setting the hour and minute at the same time, a change event occurs when the hour changes, so the problem that the minute is not set correctly has been fixed.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동작 이해하는데 시간이 좀 걸렸네요. 일단 LGTM입니다.

* @param {number} [end.hour] - end hour of range
* @param {number} beginHour - begin hour of range
* @param {number} beginMin - begin minute of range
* @param {number} [endHour] - end hour of range
* @private
*/
applyRange: function(beginHour, beginMin, endHour) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직이 eslint complexity 룰에 걸리던데 disable 주석 처리 안해도 되나요?

@jajugoguma jajugoguma merged commit 7ac52b1 into master Jan 3, 2023
@jajugoguma jajugoguma deleted the fix/set-wrong-minute branch January 3, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants