Added support for the CancelQuery() method in IStatelessSession

[SoftStoneDevelop]

Resolve #809

[fredericDelaporte]

Thanks for your contribution,

We do not accept PR without corresponding tests. See contributing. May you add a test?

[fredericDelaporte]

I have not checked all databases on my local setup, so waiting for the automated tests to do this for me.

[fredericDelaporte]

On GitHub action, AFAIK we are running SQL Server under Linux, and we seem to hit dotnet/SqlClient#109. It has been fixed in Microsoft.Data.SqlClient 2.0, but we are using System.Data.SqlClient, which is unlikely to be fixed, since Microsoft has announced it will go on developing only Microsoft.Data.SqlClient.

Should we switch Sql Server tests to Microsoft.Data.SqlClient? Well, ideally I think we should go on testing System.Data.SqlClient under .Net Framework, but test Microsoft.Data.SqlClient under net6.0.

[fredericDelaporte]

@hazzik, it seems this cancel test freezes Oracle test suit. (Maybe Oracle does not support Cancel...) The NHibernate agent on TeamCity seems gone. Can you check what is going on please?

[hazzik]

Should we switch Sql Server tests to Microsoft.Data.SqlClient?

We should at least add it to the test suit. Maybe we test it in both platforms?

[hazzik]

Ok, agent is back. I've also increased tier for the VM, so builds are slightly faster now.

[hazzik]

For some reason I cannot get any logs for Oracle

[hazzik]

Oracle on TC works fine :-/

[SoftStoneDevelop]

@hazzik
I checked locally on Oracle 19c: test passed. Perhaps the problem is that on TC Oracle 18c. In release 18c, "Manual completion of unmanaged queries" was added (https://docs.oracle.com/en/database/oracle/oracle-database/18/newft/new-features.html#GUID-EFC832BE-DC2C-4997-8C38-8A9E27A4FFC4). But from what version 18.x?

I'll try installing 18.3 on my machine and run the test: if it passes then I have no idea why TC failed.

[SoftStoneDevelop]

On 18.3 (on my local server) it works fine, all tests passed. The only difference from TC is that I have Oracle on Windows.

[SoftStoneDevelop]

On 18.3 (on my local server) it works fine, all tests passed. The only difference from TC is that I have Oracle on Windows.

"Canceled in 360m - Oracle" misled me, I checked locally for nothing. At the TC: all test(NHibernate Oracle Managed 32) pass.

[bahusoid]

"Canceled in 360m - Oracle" misled me

Why misled? There is clearly some issue with Git Hub Action build (Oracle on Linux) - https://github.com/nhibernate/nhibernate-core/runs/7643016174?check_suite_focus=true

[SoftStoneDevelop]

On "Git Hub Action" yes but not on teamcity(I initially thought that the assembly hung on the TC due to deadlock). So "misled me" means that the problem is not where I thought it was.

[hazzik]

But I wrote that:

Oracle on TC works fine :-/

[SoftStoneDevelop]

Yes, yes I am blind, sometimes.

[bahusoid]

I think we should simply skip tests for Oracle and Sql Server on linux.

[bahusoid]

SupportsCancelQuery introduction looks not necessary to me (I expected skip right inside test case). But why not.

[fredericDelaporte]

It makes for a central point for checking database limitations, which may help when we wish to check if some of these limitations do no more apply. Tests skipped directly inside them for some databases are harder to spot.

[hazzik]

Created issue to track SqlServer and Oracle #3167