Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira to GitHub: change issue naming in tests #1382

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Oct 16, 2017

We need to change our naming since the recent switch to GitHub issues from Jira. Otherwise we will have soon conflicts between old Jira test cases and new GitHub ones. I propose to replace NH by GH, since GH- is an alternate to # for referencing issues.

@@ -1,6 +1,5 @@
using System.Linq;
using NHibernate.Linq;
using NHibernate.Test.NHSpecificTest.NH0000;
Copy link
Member Author

@fredericDelaporte fredericDelaporte Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case was using directly the NH0000 entity.

@hazzik hazzik merged commit 8c820c8 into nhibernate:master Oct 16, 2017
@fredericDelaporte fredericDelaporte deleted the IssueNaming branch October 17, 2017 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants