Avoid STOP_SENDING for unknown stream type in case fin is set. #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My HTTP3 client receives a grease frame from quiche and it includes a fin.
after running gdb I see that nghttp3 does
nghttp3_conn_read_uni
and then identifiesstream->type
isNGHTTP3_STREAM_TYPE_UNKNOWN
and proceeds withconn_call_stop_sending
.Looking at RFC9114 Reserved Stream Types
If I understand this right, maybe it is never a good idea to send STOP_SENDING?