This repository has been archived by the owner on Jul 27, 2018. It is now read-only.
feat(build): Upgrade build process to emit ESM modules and a UMD bundle #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
force-pushed
the
chore-build
branch
from
77c7ef6 to
0c1be4f
Compare
MikeRyanDev
suggested changes
Sep 15, 2016
| 'rxjs/operator/distinctUntilChanged': 'Rx.Observable.prototype', | ||
| 'rxjs/operator/do': 'Rx.Observable.prototype', | ||
| 'rxjs/operator/filter': 'Rx.Observable.prototype', | ||
| 'rxjs/operator/map': 'Rx.Observable.prototype' |
There was a problem hiding this comment.
You will need to map @ngrx/core here
'@ngrx/core': 'ngrx.core'| entry: './release/index.js', | ||
| dest: './release/bundles/router-store.umd.js', | ||
| format: 'umd', | ||
| moduleName: 'ngrx.router-store', |
There was a problem hiding this comment.
The hyphen here won't work, you will need to camel-case this to ngrx.routerStore
| @@ -1,22 +1,23 @@ | |||
|
|
|||
There was a problem hiding this comment.
This legacy file was only needed for @ngrx/core to preserve deep imports. You should not need a legacy build step.
brandonroberts
force-pushed
the
chore-build
branch
from
0c1be4f to
7f6c36d
Compare
MikeRyanDev
approved these changes
Sep 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.