Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloud endpoint pooling support #582

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

Alice-Lilith
Copy link
Contributor

  • adds support in the CloudEndpoint CRD for endpoint pooling configuration (default false)
    • passes this configuration to the API calls to create/update endpoints
  • updates the Ingress -> CloudEndpoint translation to set the new field when the annotation "k8s.ngrok.com/pooling-enabled": "true" is present on the ingress.
    • ingresses with pooling enabled must have matching traffic policy annotations and must all have pooling enabled in order to share a url.
  • updates the Service -> CloudEndpoint translation to set the new field as well

@Alice-Lilith Alice-Lilith requested a review from a team as a code owner January 30, 2025 08:36
@github-actions github-actions bot added area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart labels Jan 30, 2025
@Alice-Lilith Alice-Lilith force-pushed the alicewasko/pooling-config branch from f43a9d7 to cdba0e1 Compare January 30, 2025 08:37
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 53.67232% with 82 lines in your changes missing coverage. Please review.

Project coverage is 23.87%. Comparing base (c49c5cf) to head (cdba0e1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/managerdriver/translate_ingresses.go 59.28% 52 Missing and 5 partials ⚠️
...ernal/controller/ngrok/cloudendpoint_controller.go 0.00% 14 Missing ⚠️
internal/controller/ingress/service_controller.go 0.00% 10 Missing ⚠️
internal/annotations/annotations.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   23.59%   23.87%   +0.27%     
==========================================
  Files          89       89              
  Lines       12523    12588      +65     
==========================================
+ Hits         2955     3005      +50     
- Misses       9378     9393      +15     
  Partials      190      190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alice-Lilith Alice-Lilith added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 6223451 Jan 30, 2025
10 checks passed
@Alice-Lilith Alice-Lilith deleted the alicewasko/pooling-config branch January 30, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants