Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger ci e2e with Makefile change #528

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Trigger ci e2e with Makefile change #528

merged 5 commits into from
Nov 27, 2024
+24 −11

Conversation

hjkatz
Copy link
Contributor

@hjkatz hjkatz commented Nov 27, 2024 •
edited
Loading

What

Describe what the change is solving

  • Ensure e2e cleanup steps always run
  • Ensure build-and-test steps are always run on push to main branch
  • Add debug information for the manager pod

How

Describe the solution

Breaking Changes

Are there any breaking changes in this PR?

@hjkatz hjkatz self-assigned this Nov 27, 2024
@hjkatz hjkatz requested a review from a team as a code owner November 27, 2024 15:25
@github-actions github-actions bot added the area/ci Issues/PRs relating to CI label Nov 27, 2024
@hjkatz hjkatz requested a review from jonstacks November 27, 2024 18:06
@hjkatz
Copy link
Contributor Author

hjkatz commented Nov 27, 2024

Force merging this because the build-and-test-e2e check is not required (and that's what I'm aiming to debug and fix with this PR anyways).

@hjkatz hjkatz merged commit 0fc24e4 into main Nov 27, 2024
8 of 9 checks passed
@hjkatz hjkatz deleted the hkatz/test-e2e-2 branch November 27, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonstacks jonstacks jonstacks approved these changes

Assignees

@hjkatz hjkatz

Labels
area/ci Issues/PRs relating to CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjkatz @jonstacks