Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e updates / fixes 1 #526

Merged
merged 8 commits into from
Nov 27, 2024
Merged

e2e updates / fixes 1 #526

merged 8 commits into from
Nov 27, 2024

Conversation

hjkatz
Copy link
Contributor

@hjkatz hjkatz commented Nov 26, 2024

What

Describe what the change is solving

Testing e2e and trying to get it to work. A challenge here is that pull_request_target is only taken from main so we need to merge PRs to test changes.

How

Describe the solution

  • Remove echo job (whoops)
  • Change name of build-and-test-e2e for test.yaml
  • Remove pull_request_target for ci.yaml

Breaking Changes

Are there any breaking changes in this PR?

@hjkatz hjkatz requested a review from a team as a code owner November 26, 2024 18:01
@github-actions github-actions bot added the area/ci Issues/PRs relating to CI label Nov 26, 2024
@hjkatz hjkatz changed the title Trigger ci e2e with Makefile change e2e updates / fixes 1 Nov 27, 2024
@hjkatz hjkatz self-assigned this Nov 27, 2024
@hjkatz hjkatz enabled auto-merge November 27, 2024 15:22
@hjkatz hjkatz merged commit 6604eab into main Nov 27, 2024
12 checks passed
@hjkatz hjkatz deleted the hkatz/test-e2e branch November 27, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues/PRs relating to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants