Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds in a new bindings forwarder deployment. The bindings forwarder watches for
bindingsv1alpha1.EndpointBindings
CRs and listens on the desired port so that incoming connections destined for the service have something to connect to. We still need to wire this up to connect to ngrok and forward the bytes there so that the endpoint is fully bound. For now, we simply use an example connection handler that prints information about the connection and echos back what the user inputs.How
bindings-forwarder-manager
. This sets up another manager and makes a new non leader elected controller with theForwarderReconciler
. TheForwarderReconcile
listens starts and stop listening on the configured ports as needed.Breaking Changes
No, this is all hidden behind the helm values
bindings.enabled
which defaults tofalse
.