Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings forwarder #465

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Bindings forwarder #465

merged 4 commits into from
Oct 24, 2024

Conversation

jonstacks
Copy link
Collaborator

What

This adds in a new bindings forwarder deployment. The bindings forwarder watches for bindingsv1alpha1.EndpointBindings CRs and listens on the desired port so that incoming connections destined for the service have something to connect to. We still need to wire this up to connect to ngrok and forward the bytes there so that the endpoint is fully bound. For now, we simply use an example connection handler that prints information about the connection and echos back what the user inputs.

How

  • Added the initial bindings forwarder program, bindings-forwarder-manager. This sets up another manager and makes a new non leader elected controller with the ForwarderReconciler. The ForwarderReconcile listens starts and stop listening on the configured ports as needed.
  • Added an example ConnectionHandler. We'll change this later, but for now it'll help us test
  • Added in a new Deployment, Role, Rolebinding, and (optional) service account to the helm chart

Breaking Changes

No, this is all hidden behind the helm values bindings.enabled which defaults to false.

@jonstacks jonstacks self-assigned this Oct 24, 2024
@jonstacks jonstacks requested a review from a team as a code owner October 24, 2024 20:23
@github-actions github-actions bot added area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart area/ci Issues/PRs relating to CI labels Oct 24, 2024
@github-actions github-actions bot removed the area/ci Issues/PRs relating to CI label Oct 24, 2024
@jonstacks jonstacks merged commit 334d55d into ngrok:main Oct 24, 2024
8 checks passed
@jonstacks jonstacks deleted the bindings-forwarder branch October 24, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants