Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alex/driver full usage #137

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Alex/driver full usage #137

merged 3 commits into from
Feb 14, 2023

Conversation

alex-bezek
Copy link
Collaborator

@alex-bezek alex-bezek commented Feb 10, 2023

closes: #93

What

Instead of calculating edges and other CRDs for an ingress as it reconciles, we put it in a store with all the data and calculate the total difference of crds and then synchronize them all.

How

Uses the driver and store's methods to calculate and sync the crd differences.

Breaking Changes

Hopefully not, but probably :)

Testing

I've been running through the various combinations of ingress rules/hosts from the k8s documentation which I put into our own docs to show how edges work. So far from deleting and adding individual routes and ingresses with different annotations, I haven't hit any unexpected behaviors yet. Some potential issues like clashing routes/hosts just get merged and go away unless I'm missing a point where data can be lost. I aim to add more test to cover the core functions here especially as we change them to cover other things like default backends and wildcard hosts.
The large deletion of unit tests is because all the logic has already been re-created in the driver/store with their own tests in previous PR's, so this is just removing dead code.

@alex-bezek alex-bezek requested a review from a team as a code owner February 10, 2023 05:40
@github-actions github-actions bot added area/controller Issues dealing with the controller documentation Improvements or additions to documentation testing labels Feb 10, 2023
@alex-bezek alex-bezek merged commit 7752c06 into main Feb 14, 2023
@alex-bezek alex-bezek deleted the alex/driver-full-usage branch February 14, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller documentation Improvements or additions to documentation testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement an object store to provide world view of relevant k8s objects
2 participants