Allow setting minimum TLS Version #125
Merged
+160
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/controller
alex-bezek
reviewed
Jan 27, 2023
alex-bezek
reviewed
Jan 27, 2023
alex-bezek
reviewed
Jan 27, 2023
alex-bezek
reviewed
Jan 27, 2023
alex-bezek
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows users to set the minimum TLS Version for TLS termination at Edge. If not supplied, the module will be disabled and TLS will still be terminated at the edge using the ngrok provided default.
How
Moves the annotation parsing outside of planning the routes to the edge reconciliation and then passes in the parsed annotations to the route planning since TLS termination is configured at the edge and not on the individual routes.
Breaking Changes
No